Skip to content

feat: add default client cert source util #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arithmetic1728 merged 2 commits into from
Apr 13, 2020
Merged

feat: add default client cert source util #486

arithmetic1728 merged 2 commits into from
Apr 13, 2020

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Apr 10, 2020 •
edited
Loading

  1. This is used to feed ClientOptions.client_cert_source with the default client SSL credentials.

Example usage in gapic generated client: https://github.com/arithmetic1728/mtls_grpc_sample/blob/sample/grpc_sample.py#L14

  1. Fix the keyword argument client_cert_callabck typo in configure_mtls_channel.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2020
@arithmetic1728 arithmetic1728 merged commit ed41b49 into master Apr 13, 2020
@arithmetic1728 arithmetic1728 deleted the sijun/helper branch April 13, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arithmetic1728 @busunkim96 @googlebot