Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add non-None default timeout to AuthorizedSession.request() #435

Merged
merged 2 commits into from
Jan 23, 2020
Merged

feat: add non-None default timeout to AuthorizedSession.request() #435

merged 2 commits into from
Jan 23, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 23, 2020 •
edited
Loading

Closes #434.

This PR adds a non-None default timeout to AuthorizedSession.request() to prevent requests from hanging indefinitely in a default case.

Should help with https://github.com/googleapis/google-cloud-python/issues/10182

@plamut plamut added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 23, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2020
@plamut
Copy link
Contributor Author

plamut commented Jan 23, 2020 •
edited
Loading

Well go figure, running the blacken session can cause syntax errors, because a trailing comma is not allowed after **kwargs in Python <= 3.5. 😄

@plamut plamut mentioned this pull request Jan 23, 2020
Merged
@busunkim96 busunkim96 merged commit d274a3a into googleapis:master Jan 23, 2020
@plamut plamut deleted the iss-434 branch January 24, 2020 07:05
@hiranya911 hiranya911 mentioned this pull request Jan 29, 2020
Closed
rsgowman added a commit to firebase/firebase-admin-python that referenced this pull request Jan 29, 2020
@rsgowman
Fix broken test (which relied on default timeout being None).
1c845a0 
The upstream behaviour has changed such that None is no longer the
default:

googleapis/google-auth-library-python#435
@rsgowman rsgowman mentioned this pull request Jan 29, 2020
Closed
@hiranya911 hiranya911 mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox left review comments

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set the default request timeout to something other than None
4 participants
@plamut @crwilcox @busunkim96 @googlebot