Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert "feat: add timeout parameter to AuthorizedSession.request()" #401

Merged
merged 1 commit into from
Dec 9, 2019
Merged

fix: revert "feat: add timeout parameter to AuthorizedSession.request()" #401

merged 1 commit into from
Dec 9, 2019

Conversation

busunkim96
Copy link
Contributor

Reverts #397

Rolling this back as a bug opened on a repo using google-cloud-storage started failing and this seems like the most probable cause. googleapis/docuploader#22

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2019
@busunkim96 busunkim96 changed the title Revert "feat: add timeout parameter to AuthorizedSession.request()" fix: revert "feat: add timeout parameter to AuthorizedSession.request()" Dec 9, 2019
@busunkim96 busunkim96 merged commit 451ecbd into master Dec 9, 2019
@busunkim96 busunkim96 mentioned this pull request Dec 9, 2019
Closed
@plamut plamut mentioned this pull request Dec 10, 2019
Closed
@busunkim96 busunkim96 deleted the revert-397-add-timeout-param branch December 16, 2019 18:51
@yoshi-automation yoshi-automation mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @crwilcox @googlebot