Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify intended procedure for detecting when a new access token has been generated and how/whether to store it #3568

Open
6 tasks done
calculuschild opened this issue Oct 1, 2024 · 0 comments

Comments

@calculuschild
Copy link

calculuschild commented Oct 1, 2024

Please make sure you have searched for information in the following guides.

Documentation Request

When an access token is expired, performing an API request will automatically use the refresh token to fetch a new access token. However, this does not trigger the on('tokens) event; this only fires on the first authentication.

What is not explained clearly in the docs then, is how the new access token is meant to be detected so that it can be stored and reused for its validity period. Otherwise the new access token may be lost and users hit 401 Invalid Credentials errors in subsequent requests.

Is the intent that after each API call, we manually check the oAuth2Client for a new access token via oAuth2Client.credentials.access_token? I.e., add manual token checking logic after each API call? If this is the case, can explicit instructions be added that something like this is the intended approach?

Or is there some other event similar to tokens we can listen for on the oAuth2Client that will automatically trigger upon receiving an updated access token? (If not, can that feature be added?)

Perhaps the access token is not meant to be stored at all? Discarded after each request? But then we are fetching new access tokens for every request after the first hour.

@calculuschild calculuschild changed the title How to detect when a new access token has been generated Expected procedure for detecting when a new access token has been generated Oct 1, 2024
@calculuschild calculuschild changed the title Expected procedure for detecting when a new access token has been generated Clarify intended procedure for detecting when a new access token has been generated Oct 1, 2024
@calculuschild calculuschild changed the title Clarify intended procedure for detecting when a new access token has been generated Clarify intended procedure for detecting when a new access token has been generated and how/whether to store it Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@calculuschild and others