Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for clearer examples and improved types for FHIR search in @googleapis/healthcare library #3549

Open
mohsinht opened this issue Sep 4, 2024 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mohsinht
Copy link

mohsinht commented Sep 4, 2024

Is your feature request related to a problem? Please describe.

I’m trying to search the FHIR store using the @googleapis/healthcare library, specifically the projects.locations.datasets.fhirStores.fhir.search method, but I have encountered several issues:

  1. The documentation and examples are very vague, particularly for performing search queries using GET and POST.
  2. The query structure I’m trying to use, for example: Observation?combo-code=mysite.com|bmi&subject=Patient/some-id, does not seem to fit easily within the current structure of the @googleapis/healthcare search method.
  3. The search method parameters and types are not clearly defined or typed within the library, leading to confusion and difficulty in usage.

Describe the solution you'd like

I would like clearer examples and documentation for using the search method, specifically with both GET and POST requests. It would be helpful to show how to handle FHIR query strings such as Observation?combo-code=mysite.com|bmi&subject=Patient/some-id in the @googleapis/healthcare library. Additionally, proper TypeScript typings for these search parameters would greatly improve the developer experience.

Describe alternatives you've considered

I have considered bypassing the library and making direct HTTP requests with the Google Auth library, but that adds complexity and seems like an unnecessary workaround.

Additional context

The StackOverflow community also has threads discussing the vague types and lack of clarity around using the search method. More detailed samples and clearer type definitions would go a long way in making the library more accessible and easier to use.

@mohsinht mohsinht added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 4, 2024
@mohsinht
Copy link
Author

mohsinht commented Sep 4, 2024

There's unanswered thread here as well: #2555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant