Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation around flagger.app/config-tracking is lacking #1704

Open
WaDelma opened this issue Sep 13, 2024 · 0 comments
Open

Documentation around flagger.app/config-tracking is lacking #1704

WaDelma opened this issue Sep 13, 2024 · 0 comments

Comments

@WaDelma
Copy link

WaDelma commented Sep 13, 2024 •
edited
Loading

So when I read

flagger/docs/gitbook/usage/how-it-works.md

Lines 116 to 117 in b6ac5e1

If you annotate your ConfigMap or Secret with `flagger.app/config-tracking: disabled`,
Flagger will use the same object for the primary deployment instead of making a primary copy.

I thought that when adding this annotation flagger would now update canary and trigger rollout to primary deployment directly with the changes in the configmap/secret.

This doesn't seem to be the case.

The documentation should be made clearer in this regard. Maybe example could added how to get this behavior as doing checksum pattern on deployment won't work as that would just trigger flagger analysis. One option that I have thought would be to use sidecar that watches configmap/secret values and restarts pods.

Alternatively feature could be added to flagger for doing this. Maybe there already is and I am just missing it 🤷‍♀️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WaDelma