We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We created a headless service for our application and created a Canary resource to enable Flagger.
However, after creating Canary resources we found, that service resources created by Flagger are not headless services.
After a short investigation, we found this code:
flagger/pkg/canary/service_controller.go
Line 134 in 9b39cf1
Which looks like a reset field to avoid errors on resource creation, but not for forbidding using headless services.
So the question is: is it intended not to preserve the headless service type?
Check for the ClusterIP: None value to decide on the reset field ClusterIP value.
ClusterIP: None
ClusterIP
N/A
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the feature
We created a headless service for our application and created a Canary resource to enable Flagger.
However, after creating Canary resources we found, that service resources created by Flagger are not headless services.
After a short investigation, we found this code:
flagger/pkg/canary/service_controller.go
Line 134 in 9b39cf1
Which looks like a reset field to avoid errors on resource creation, but not for forbidding using headless services.
So the question is: is it intended not to preserve the headless service type?
Proposed solution
Check for the
ClusterIP: None
value to decide on the reset fieldClusterIP
value.Any alternatives you've considered?
N/A
The text was updated successfully, but these errors were encountered: