Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search page topics will not populate from aggregated results if a search with no results has occurred. #953

Open
alan-cole opened this issue May 14, 2021 · 3 comments
Open

Search page topics will not populate from aggregated results if a search with no results has occurred. #953

alan-cole opened this issue May 14, 2021 · 3 comments
Labels
bug report contributions-welcome Pull Requests welcome for this issue!

Comments

@alan-cole
Copy link
Collaborator

alan-cole commented May 14, 2021 •
edited
Loading

Describe the bug
Search page topics will not populate from aggregated results if a search with no results has occurred.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to /search
  2. Search for "Bill" and apply.
  3. Results are returned - check the topics - should be populated with options for topics.
  4. Search for "sasafsafdsfdsafdsa" and apply.
  5. No results are returned - check the topics - no options will show upon clicking the field.
  6. Search for "Bill" and apply.
  7. Results are returned - check the topics - no options will be available where there should be options.

Expected behaviour
Upon step 7, results should show the same as they did in step 3.

Actual behaviour
No results show.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • Ripple: Current vic.gov.au site (1.21.2)

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Firefox
  • Version 89

Additional context
Searching "Bill" then "Cheese" then "Bill" will show the correct results each time, it's only if zero results occur that this breaks.
It's likely that setting a null value on the form field means that a non-null value doesn't update the model correctly.
@dylankelly
Copy link
Contributor

Hi @alan-cole - thanks for the bug report. This seems to relate to a very old ticket SDPA-1255 that was closed as not needed by Mike Laidlaw on September 25, 2019.

Given we have been considering a search replacement for a number of years I think we should fix this issue. I have reopened the ticket and will update you when I know anything further.

@dylankelly dylankelly added the contributions-welcome Pull Requests welcome for this issue! label Jun 17, 2021
@jlstant
Copy link
Contributor

jlstant commented Sep 3, 2021

This issue appears to be fixed, I just tested it and it seems to work just fine given the steps to reproduce outlined above.

@alan-cole
Copy link
Collaborator Author

I'm still able to replicate this on vic.gov.au:

issue-953.mp4

Given the content collection has become an option since this ticket was opened, the search page could be replaced with a content collection to solve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report contributions-welcome Pull Requests welcome for this issue!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dylankelly @alan-cole @jlstant