Skip to content

getBaseUrl incorrectly setting the request protocol #1201

Open
@dylankelly

Description

See https://digital-engagement.atlassian.net/browse/SDPSUP-4331

Requests made in HTTPS environments are not correctly setting the baseUrl for requests to the ripple-search-api endpoint when used in a secure HTTPS environment.

See https://github.com/dpc-sdp/ripple/blob/develop/packages/ripple-nuxt-tide/lib/templates/plugin.js#L25

Suggested solution

Check req has secure property set and use that instead.

See https://stackoverflow.com/questions/10348906/how-to-know-if-a-request-is-http-or-https-in-node-js

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions