Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria 1.2 support for useSelect #1365

Closed
tu4mo opened this issue Mar 7, 2022 · 5 comments · Fixed by #1415
Closed

Aria 1.2 support for useSelect #1365

tu4mo opened this issue Mar 7, 2022 · 5 comments · Fixed by #1415
Labels
BREAKING CHANGE enhancement help wanted

Comments

@tu4mo
Copy link
Contributor

tu4mo commented Mar 7, 2022 •
edited by silviuaavram
Loading

Migrate useSelect from 1.1 to 1.2 ARIA pattern.
@silviuaavram
Copy link
Collaborator

What component/hook are we talking about?

@silviuaavram
Copy link
Collaborator

Are you talking about https://www.w3.org/TR/wai-aria-practices-1.2/examples/combobox/combobox-select-only.html ?

@tu4mo
Copy link
Contributor Author

tu4mo commented Mar 7, 2022

It's an issue with both useSelect and useCombobox (if you don't filter items). I'm mostly comparing with behavior of native select and other select libraries like react-select.

@silviuaavram
Copy link
Collaborator

The reason for this behaviour is that we currently follow https://www.w3.org/TR/wai-aria-practices-1.2/examples/listbox/listbox-collapsible.html. We should update our hooks to reflect this. I will keep this issue open to track it.

@silviuaavram silviuaavram mentioned this issue Mar 7, 2022
Closed
@silviuaavram silviuaavram changed the title Pressing arrow down the first time should only open the menu Aria 1.2 support for useSelect Mar 7, 2022
@tpict
Copy link

tpict commented May 12, 2022

The new spec seems to shed some light on #935, too!

@silviuaavram silviuaavram mentioned this issue Aug 13, 2022
Closed
@silviuaavram silviuaavram mentioned this issue Aug 21, 2022
Closed
24 tasks
@sholzmayer sholzmayer mentioned this issue Oct 7, 2022
Closed
5 tasks
@silviuaavram silviuaavram mentioned this issue Oct 21, 2022
Merged
silviuaavram added a commit that referenced this issue Oct 22, 2022
@silviuaavram
feat: downshift v7 (#1415)
7540e3d 
BREAKING CHANGE: updates to useCombobox and useSelect to adhere to the 1.2 version of the ARIA Combobox pattern.

Migration guide is available in [this file](https://github.com/downshift-js/downshift/tree/master/src/hooks/MIGRATION_V7.md).

Closes #1365.
Closes #1239.
Contains changes from #1149.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING CHANGE enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: v7 downshift-js/downshift
feat: update useSelect to the ARIA 1.2 pattern downshift-js/downshift
3 participants
@silviuaavram @tpict @tu4mo