Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't see actual (non avg) values for latest day #153

Open
djay opened this issue Oct 28, 2021 · 4 comments
Open

can't see actual (non avg) values for latest day #153

djay opened this issue Oct 28, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request UI Improving plots or website

Comments

@djay
Copy link
Owner

djay commented Oct 28, 2021

Currently the right y axis shows a value but its unclear if this is avg or actual value for plots that using 7 day MA.
It would be good to show both and make it clear which is which.

e.g. 215/200 with an label somewhere showing VAL/AVG. Since this will take less space?

some plots might not matter like % ones so should be option to turn off?

Another way to solve this might be #163

@djay djay added enhancement New feature or request UI Improving plots or website labels Oct 28, 2021
@modiholodri
Copy link
Collaborator

modiholodri commented Oct 28, 2021

@djay Copied from PR #152. Maybe we should fix the definitions. That's how I see it at the moment...
Actual - The value at the end of the line or patch. (Not the axis grid values.)
Current - The current value (not average).
Average - The rolling average.
Relative - In percent.
Absolute - In units.

Your suggest makes sense. The thing is that formatters just take a single value and not two basically "independent" values. So you would have to tell me how to get the value pairs. Or maybe just show the average and the current lines as it is done already in some plots, then both could be shown. No value is shown at the moment and it's also not in the legend (probably all lines should be in the legend)...
image

Another idea could also be to show the relative and absolute values for more plots similar to the population formatter.

@djay
Copy link
Owner Author

djay commented Oct 28, 2021

By actual I mean the non averaged value. Thats how I've used it in the code.
although the actuals param I've misused a couple of times. I use it for instance to show future predictions on the vaccine chart. Possible I could change the params around to make that distinction.
I don't think current is a good word for that since it implies the latest date.

@djay djay changed the title can't see actual values for latest day can't see actual (non avg) values for latest day Oct 28, 2021
@modiholodri
Copy link
Collaborator

Maybe call the values shown on axis last values, similar to what I called it in the code before I removed it.

@djay
Copy link
Owner Author

djay commented Oct 28, 2021

sure. so what would be good is for the last values to show both the avg value and the actual (non avg) value. so the in example above it would show 47K/39K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI Improving plots or website
Projects
None yet
Development

No branches or pull requests

2 participants