Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use incremental sync on Windows #18039

Open
1 of 2 tasks
Prabhanjali opened this issue May 22, 2024 · 1 comment
Open
1 of 2 tasks

Unable to use incremental sync on Windows #18039

Prabhanjali opened this issue May 22, 2024 · 1 comment
Labels
area/plugin-sdk/go kind/bug os/windows

Comments

@Prabhanjali
Copy link

Prabhanjali commented May 22, 2024 •
edited by erezrokah
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I am using AWS Plugin 24.1.0, Postgresql version 7.0.0, AWS CLI is 5.20.1.
While trying to use a incremental sync for aws_inspector2_findings table, I am running into the below issues.

Error:

 unexpected error from sync client receive: rpc error: code = Unavailable desc = failed to sync records: failed to sync unmanaged client: failed to create state client: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp: address: too many colons in address"

Expected Behavior

Incremental sync to work without error

CloudQuery (redacted) config

source.yml

kind: source
spec:
  # Source spec section
  name: aws_xxxxxx
  path: cloudquery/aws
  version: "v24.1.0"
  tables: ["aws_inspector2_findings"]
  destinations: ["postgresql"]
  backend_options:
    table_name: "cq_state_aws"
    connection: "@@plugins.postgresql.connection"

postgresql.yml

kind: destination
spec:
  name: postgresql
  path: "cloudquery/postgresql"
  version: "v7.0.0"
  write_mode: "overwrite-delete-stale"
  migrate_mode: "forced"
  spec:
    connection_string: "xxxxxxxxxx"

Steps To Reproduce

No response

CloudQuery (redacted) logs

..

CloudQuery version

5.20.1

Additional Context

OS is Windows using bash terminal

Pull request (optional)

  • I can submit a pull request
@erezrokah erezrokah moved this to Ready in Data Framework May 23, 2024
@erezrokah
Copy link
Member

Looks like we're using a unix only feature for the state client:
https://github.com/cloudquery/plugin-pb-go/blob/d34a2c510353ebcf4c8b7fc655e59f1a7ae52711/managedplugin/plugin.go#L255

cloudquery/cli/cmd/sync_v3.go

Line 118 in 85f0d9b

connection := destinationsClients[i].ConnectionString()

Where we should be doing https://github.com/cloudquery/plugin-pb-go/blob/d34a2c510353ebcf4c8b7fc655e59f1a7ae52711/managedplugin/plugin.go#L514

@erezrokah erezrokah changed the title Unable to use incremental sync in local - failed to sync unmanaged client: failed to create state client: rpc error Unable to use incremental sync on Windows Jun 11, 2024
@erezrokah erezrokah mentioned this issue Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugin-sdk/go kind/bug os/windows
Projects
Data Framework
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erezrokah @Prabhanjali