fix: messages overlap when switching tabs too quickly #10511
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoaoLive100 Thanks for the PR. I understand the issue. However, I believe the most suitable solution is to utilize AbortController, as it’s natively available and eliminates the need for managing counters. Let me know what you think. https://developer.mozilla.org/en-US/docs/Web/API/AbortController |
|
@pranavrajs I made the changes implementing the AbortController. It’s a solution I wasn’t familiar with, but it achieved the expected result in addressing the issue. What do you think of the current implementation? Please proceed with your review. |
|
🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
When switching between message categories ('All Conversations', 'Mentions', 'Unattended'), the messages displayed should correspond to the selected category. If I switch categories quickly, messages from the previously selected category sometimes appear in the new one. It seems that messages from one category are being loaded into another due to some delay or overlapping request handling.
An incremental identifier ensures that only the data from the most recent request is processed.
Type of change
How Has This Been Tested?
Simulated rapid switching between message categories ('All Conversations', 'Mentions', and 'Unattended') to replicate the conditions where messages from one category were loaded into another. After the code update, performed the same rapid switching to confirm that messages now load correctly and correspond to the selected category without overlap.
Checklist: