Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: endless loop in nextAvailabilityTime mixin #10354

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: endless loop in nextAvailabilityTime mixin #10354

wants to merge 3 commits into from
+13 −1

Conversation

honzasterba
Copy link
Contributor

Pull Request Template

Description

Add safeguards so that working hours does not get stuck in endless loop but maintains working condition. Please instruct on how to best test this change.

Fixes #10353

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual testing to verify that it fixes the bug described in linked issue.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

scmmishra
scmmishra requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@scmmishra scmmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @honzasterba can share the data that can be used to reproduce this issue, also it would be great to add tests to nextAvailabilityTime.spec.js for this case which would cause an endless loop.

@scmmishra scmmishra changed the title [bugfix] fix endless loop in nextAvailabilityTime fix: endless loop in nextAvailabilityTime mixin Oct 30, 2024
@honzasterba
Copy link
Contributor Author

What format would you like the data in? What data exactly? I believe the bug description contains everything needed to reproduce the bug.

iamsivin
iamsivin reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@iamsivin iamsivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@honzasterba Thanks for raising this PR! I pulled it locally for testing, and while it does fix the infinite loop issue, I noticed that it causes the widget to break and throws some errors (see the attached screenshot). Let me know if you need any help with this!.

image

Loom video
https://www.loom.com/share/c3e884760ba1487b84e03c949be83870?sid=c7eea192-d74b-499d-a275-b8c208b5c1ef

@github-actions GitHub Actions
Copy link

🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild?

@github-actions github-actions bot added the stale label Nov 30, 2024
@github-actions github-actions bot removed the stale label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsivin iamsivin iamsivin left review comments

@scmmishra scmmishra scmmishra requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@scmmishra scmmishra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website widget freezes the browser process in infinite loop
4 participants
@honzasterba @scmmishra @iamsivin @muhsin-k