chore: Append context menu to the app wrapper element instead to support RTL. #10331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the ContextMenu.vue component does not work with RTL support, since dir="rtl" attribute is being appended to the <div class="app-wrapper...> element, not in the <body>.
coolayatuvxtech
changed the title
coolayatuvxtech
changed the title
coolayatuvxtech
changed the title
scmmishra
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Hey @coolayatuvxtech thanks for the contribution and apologies it took a while to get the review.
Moving this to the .app-wrapper can have unintended effects on the layout. You could refer to components-next/dialog component, there we solve this by adding the dir to this component directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the ContextMenu.vue component does not work with RTL support, since dir="rtl" attribute is being appended to the <div class="app-wrapper...> element, not in the .
Description
This PR addresses an issue with the
ContextMenu.vuecomponent, where RTL (Right-to-Left) support was not working as expected. Previously, thedir="rtl"attribute was being appended to the<div class="app-wrapper...>element instead of the<body>element. The fix involved appending the context menu to the<div class="app-wrapper...>element to ensure proper RTL rendering.Fixes # (issue number here)
Type of change
How Has This Been Tested?
The fix was tested by:
<div class="app-wrapper...>element and verifying that RTL support works as expected.Checklist: