-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylint alerts corrections as part of intervention experiment #434
Comments
Of course, code improvement are appreciated! However, it's not clear to me how much effort this requires on my part. Since I don't have much free time nowadays, I cannot promise I can respond in a timely manner. |
I'll try not to require too much from you. After that, you'll ask you to review the PR. |
I fixed the pylint alert and created a PR. I notice that the setup for development doe not use requirements file. |
The alert in src\rinoh\hyphenator.py seems to identify a bug and not a refactoring opportunity.all = ("Hyphenator") while it should be a list (e.g. all = ["Hyphenator"]). https://stackoverflow.com/questions/44834/what-does-all-mean-in-python In src\rinoh\highlight.py and src\rinoh\frontend\sphinx\nodes.py there are alerts on using-constant-test. |
In src\rinoh\frontend\rst\nodes.py there is an alert on pointless statment. def children_flowables(self, skip_first=0): |
In src\rinoh\element.py method build_document of class DocumentElement has an empty implementation of pass. |
In src\rinoh\stylesheets\matcher.py there is a wildcard import. @brechtm, can you guide me regadding these cases? |
I'd like to conduct a software engineering experiment regarding the benefit of Pylint alerts removal.
The experiment is described here.
In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control.
After the interventions are done, one can wait and examine the results.
I'm asking your approval for conducting the interventions in your repositories.The interventions are expected to benefit the project and will submitted in PR for approval.
See examples of interventions in stanford-oval/storm, gabfl/vault, and coreruleset/coreruleset.
See the planed internetions.
@brechtm, Is it OK if I'll fix the alerts?
The text was updated successfully, but these errors were encountered: