chore: update LastActivityDate on installation token refresh
#5081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisonbeck
changed the base branch from
main
to
platform/addison/PM-11129/installation-activity-column
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
2 times, most recently
from
9e88cdc to
c75ad00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5081 +/- ##
=======================================
Coverage 43.70% 43.70%
=======================================
Files 1469 1472 +3
Lines 67901 67963 +62
Branches 6156 6161 +5
=======================================
+ Hits 29673 29703 +30
- Misses 36934 36963 +29
- Partials 1294 1297 +3 ☔ View full report in Codecov by Sentry. |
Contributor
|
No New Or Fixed Issues Found |
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
6 times, most recently
from
da7f372 to
3c89f31
Compare
addisonbeck
changed the base branch from
platform/addison/PM-11129/installation-activity-column
to
platform/addison/PM-11129/codeownership-assignments
addisonbeck
changed the base branch from
platform/addison/PM-11129/codeownership-assignments
to
platform/addison/PM-11129/codeowners
addisonbeck
force-pushed
the
platform/addison/PM-11129/codeowners
branch
2 times, most recently
from
0517a00 to
c785e42
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
from
3c89f31 to
18fb3b1
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/codeowners
branch
from
c785e42 to
15200dd
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
7 times, most recently
from
15b2557 to
5db4a74
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/codeowners
branch
4 times, most recently
from
3681561 to
a99393b
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
from
5db4a74 to
1a19adf
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/codeowners
branch
from
a99393b to
80d9f02
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
2 times, most recently
from
6a6bd09 to
863b401
Compare
Contributor
LaunchDarkly flag references🔍 1 flag added or modified
|
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
from
4d1fe89 to
5e59227
Compare
addisonbeck
changed the title
Installation.LastActivityDate on installation token refreshLastActivityDate on installation token refresh
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
from
5e59227 to
e761431
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/codeowners
branch
from
a7d904a to
75bd011
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/codeowners
branch
7 times, most recently
from
6ab06c5 to
c3a3951
Compare
addisonbeck
force-pushed
the
platform/addison/PM-11129/implementation
branch
from
e761431 to
4dcf260
Compare
addisonbeck
requested review from
coroiu,
ike-kottlowski and
tangowithfoxtrot
and removed request for
coroiu
ike-kottlowski
approved these changes
Jan 6, 2025
Contributor
ike-kottlowski
left a comment
ike-kottlowski
left a comment
There was a problem hiding this comment.
Auth changes are good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11129
📔 Objective
In previous commits a
LastActivityDatefield was added to the database. This commit implements that column by writing the current date whenever an installation refreshes its token for push relay.📸 Screenshots
demo_720.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes