util: use explicit cast in MultiIntBitSet::Fill()

vasild · vasild · commit edb41e4814cc · 2024-12-05T16:55:36.000+01:00
The current code does not have a bug, but is implicitly casting -1 to
65535 and the sanitizer has no way to know whether we intend that or
not.

```
FUZZ=bitset src/test/fuzz/fuzz /tmp/fuz

error: implicit conversion from type 'int' of value -1 (32-bit, signed)
to type 'value_type' (aka 'unsigned short') changed the value to 65535
(16-bit, unsigned)

Base64: Qv7bX/8=
```
diff --git a/src/util/bitset.h b/src/util/bitset.h
@@ -366,7 +366,7 @@ class MultiIntBitSet
         if (count) {
             unsigned i = 0;
             while (count > LIMB_BITS) {
-                ret.m_val[i++] = ~I{0};
+                ret.m_val[i++] = I(~I{0});
                 count -= LIMB_BITS;
             }
             ret.m_val[i] = I(~I{0}) >> (LIMB_BITS - count);

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ class MultiIntBitSet`
`366`	`366`	`if (count) {`
`367`	`367`	`unsigned i = 0;`
`368`	`368`	`while (count > LIMB_BITS) {`
`369`		`- ret.m_val[i++] = ~I{0};`
	`369`	`+ ret.m_val[i++] = I(~I{0});`
`370`	`370`	`count -= LIMB_BITS;`
`371`	`371`	`}`
`372`	`372`	`ret.m_val[i] = I(~I{0}) >> (LIMB_BITS - count);`