🐛 Bug Report: publish:github:pull-request does not support deletion of files #28112
Open
2 tasks done
Labels
bug
Something isn't working
📜 Description
When I use the scaffolder action 'publish:github:pull-request' in a template this does not support the "deletion" of files that where previously in the git repository
it should support that
👍 Expected behavior
If I checkout a repository, remove a file and then create a pull request the pull request should actually have a file deletion marker for this file and merging the PR should delete this.
👎 Actual Behavior with Screenshots
The created PR in Github is "empty" - no files are visible in it....
👟 Reproduction steps
Using this template
📃 Provide the context for the Bug.
This is where the files are read
backstage/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.ts
Lines 335 to 353 in a65f2d5
and then they are added to the PR here:
backstage/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.ts
Lines 370 to 372 in a65f2d5
obviously, a file that was deleted will never be added as a "change set" :-(
🖥️ Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?
🏢 Have you read the Code of Conduct?
Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else
The text was updated successfully, but these errors were encountered: