feat(GitHubOrgEntityProvider): adds throttling and rate limit handling to GithubOrgEntityProvider #28085
+222
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sonikro
force-pushed
the
add-throttling-and-rate-limit-github-entity-provider
branch
3 times, most recently
from
ba5204b to
3dbb65a
Compare
…ubOrgEntityProvider Signed-off-by: sonikro <[email protected]>
sonikro
force-pushed
the
add-throttling-and-rate-limit-github-entity-provider
branch
from
3dbb65a to
b92790e
Compare
sonikro
changed the title
|
Something seems flaky in the Windows E2E test. Can someone retry that ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
When using the GithubOrgEntityProvider in organizations with over 14000 users on a GitHub Organization, the EntityProvider was failing 100% of the time with Secondary Rate Limit errors.
This fix adds the official throttling plugin to the graphql client responsible for fetching the data.
I tested this package locally and not only the rate limit consumption went down significantly, but when a rate limit error happened, it successfully retried and moved on.
PS: Using octokit versions on this monorepo is getting complicated, as there are so many different versions installed. I spent most of my time trying to find the exact octokit versions I could use that would not break types everywhere.
✔️ Checklist
Signed-off-byline in the message. (more info)