New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axios does have side effects, despite sideEffects=false #6718

Open

aryzing opened this issue Nov 26, 2024 · 0 comments

aryzing commented Nov 26, 2024 •

edited

Loading

Describe the bug

This line claims the axios package has no side effects,

axios/package.json

Line 175 in 415ca94

"sideEffects": false,

which seems to be at odds with this top-level function call,

axios/lib/axios.js

Line 47 in 415ca94

const axios = createInstance(defaults);

Am I missing something here? Seems that function call is at the top level and will run when the package is imported, thus producing side-effects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment