Allow all headers to be set to an empty value (#547)

aws · Oct 8, 2024 · e6338ca · e6338ca
1 parent e3a9df9
commit e6338ca
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/...main/java/software/amazon/smithy/go/codegen/integration/HttpBindingProtocolGenerator.java b/...main/java/software/amazon/smithy/go/codegen/integration/HttpBindingProtocolGenerator.java
@@ -852,10 +852,8 @@ private void writeHttpBindingMember(
                     });
         }
 
-        boolean allowZeroStrings = location != HttpBinding.Location.HEADER;
-
         GoValueAccessUtils.writeIfNonZeroValueMember(context.getModel(), context.getSymbolProvider(), writer,
-                memberShape, "v", allowZeroStrings, memberShape.isRequired(), (operand) -> {
+                memberShape, "v", true, memberShape.isRequired(), (operand) -> {
                     final String locationName = binding.getLocationName().isEmpty()
                             ? memberShape.getMemberName() : binding.getLocationName();
                     switch (location) {
@@ -980,6 +978,13 @@ private void writeHeaderBinding(
         }
 
         MemberShape collectionMemberShape = CodegenUtils.expectCollectionShape(targetShape).getMember();
+        // On empty collection header will be set to an empty value
+        writer.openBlock("if len($L) == 0 {", "}", operand, () -> {
+            writeHttpBindingSetter(context, writer, collectionMemberShape, location, operand,
+                    (w, s) -> {
+                        w.writeInline("$L.AddHeader($L).String(\"\")", dest, locationName);
+                    });
+        });
         writer.openBlock("for i := range $L {", "}", operand, () -> {
             // Only set non-empty non-nil header values
             String indexedOperand = operand + "[i]";