Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: SDK call logging doesn't work anymore since SDKv3 #32306

Closed
1 task
rix0rrr opened this issue Nov 27, 2024 · 3 comments · Fixed by #32308
Closed
1 task

CLI: SDK call logging doesn't work anymore since SDKv3 #32306

rix0rrr opened this issue Nov 27, 2024 · 3 comments · Fixed by #32308
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 27, 2024

Describe the bug

Compare these 2 logs:

>> v2.166.0
[13:59:43] Assuming role 'arn:aws:iam::012345678901:role/cdk-REDACTED-lookup-role-012345678901-ap-northeast-1'.
[13:59:43] [trace]   SDK#forceCredentialRetrieval()
[13:59:43] [trace] SDK#ssm()
[13:59:43] [trace]   SDK#wrapServiceErrorHandling()
[13:59:43] [AWS ssm 200 0.296s 0 retries] getParameter({ Name: '/cdk-bootstrap/REDACTED/version' })
[13:59:43] [trace] SDK#cloudFormation()
[13:59:43] [trace]   SDK#wrapServiceErrorHandling()
[13:59:44] [AWS cloudformation 200 0.209s 0 retries] describeStacks({ StackName: 'REDACTED' })
[13:59:44] [AWS cloudformation 200 0.122s 0 retries] getTemplate({ StackName: 'REDACTED', TemplateStage: 'Original' })
[13:59:44] [trace] SdkProvider#resolveEnvironment()

>> v2.171.1-rc.0-16d61b1
[17:36:40] Assuming role 'arn:aws:iam::REDACTED:role/cdk-REDACTED-lookup-role-REDACTED-ap-northeast-1'.
[17:36:46] [trace] SDK#ssm()
[17:36:56] [trace] SDK#cloudFormation()
[17:37:09] [trace] SdkProvider#resolveEnvironment()

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

Current Behavior

Reproduction Steps

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

Framework Version

No response

Node.js Version

OS

Language

TypeScript

Language Version

No response

Other information

No response
@rix0rrr rix0rrr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 27, 2024
@rix0rrr rix0rrr mentioned this issue Nov 27, 2024
Merged
@ashishdhingra
Copy link
Contributor

Opened by CDK team. Adding p1 label since we have corresponding PR.

@ashishdhingra ashishdhingra added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2024
@mergify mergify bot closed this as completed in #32308 Nov 28, 2024
@mergify mergify bot closed this as completed in d2e0b29 Nov 28, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cli): log SDK calls when using -vvv aws/aws-cdk
3 participants
@otaviomacedo @rix0rrr @ashishdhingra