Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-flags: redesign #21853

Open
2 tasks
TheRealAmazonKendra opened this issue Aug 31, 2022 · 2 comments
Open
2 tasks

feature-flags: redesign #21853

TheRealAmazonKendra opened this issue Aug 31, 2022 · 2 comments
Labels
@aws-cdk/core Related to core CDK functionality management/tracking Issues that track a subject or multiple issues needs-design This feature request needs additional design work. p2

Comments

@TheRealAmazonKendra
Copy link
Contributor

Describe the feature

Feature flags need a redesign. Opening this issue to track this.

Use Case

User friendly flags with proper documentation so that users can easily turn on/off functionality.

Proposed Solution

TBD

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

N/A

Environment details (OS name and version, etc.)

N/A
@TheRealAmazonKendra TheRealAmazonKendra added @aws-cdk/core Related to core CDK functionality needs-design This feature request needs additional design work. labels Aug 31, 2022
@TheRealAmazonKendra TheRealAmazonKendra self-assigned this Aug 31, 2022
@gshpychka
Copy link
Contributor

Could you explain the rationale - what's wrong with the current design?

@TheRealAmazonKendra
Copy link
Contributor Author

They were designed to be a temporary bandaid between v1 and v2 but they've become a permanent fixture. There is a lot of confusion about using them, the helper functions for unit testing doesn't work correctly in v2, we use commenting to do a lot of heavy lifting when defining them, and the documentation is wrong/inaccurate/incomplete in multiple places. I opened this issue to track the work I'm doing to correct all of the above.

@peterwoodworth peterwoodworth added the management/tracking Issues that track a subject or multiple issues label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/core Related to core CDK functionality management/tracking Issues that track a subject or multiple issues needs-design This feature request needs additional design work. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gshpychka @peterwoodworth @TheRealAmazonKendra @ashishdhingra