Skip to content

Library: Fix: RP2040 xtal and test_en connections in pinmap#597

Merged
iopapamanoglou merged 4 commits intomainfrom
bugfix/faebryk_library_rp2040_pinout
Dec 10, 2024
Merged

Library: Fix: RP2040 xtal and test_en connections in pinmap#597
iopapamanoglou merged 4 commits intomainfrom
bugfix/faebryk_library_rp2040_pinout

Conversation

@ruben-iteng
Copy link
Contributor

Library: Fix: RP2040 xtal and test_en connections in pinmap

Description

Found out the hard(ware) way 🥲

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@ruben-iteng ruben-iteng added the bug Something isn't working label Nov 29, 2024
@ruben-iteng ruben-iteng self-assigned this Nov 29, 2024
@mawildoer
Copy link
Contributor

@ruben-iteng Thanks for the PR! If you're sure about this, I'll mash that merge. Any reason it's still in draft state

@ruben-iteng ruben-iteng marked this pull request as ready for review December 5, 2024 18:49
@iopapamanoglou iopapamanoglou merged commit 094823c into main Dec 10, 2024
@iopapamanoglou iopapamanoglou deleted the bugfix/faebryk_library_rp2040_pinout branch December 10, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants