Merged
Conversation
Move it to a folder, such that we can implement the new version in the parameter namespace.
mostly renaming
mawildoer
approved these changes
Dec 6, 2024
Collaborator
mawildoer
left a comment
mawildoer
left a comment
There was a problem hiding this comment.
Love to still address the ERC voltage missing
src/faebryk/libs/logging.py
Outdated
| console=Console( | ||
| safe_box=False, | ||
| theme=theme, | ||
| force_terminal=True, |
Collaborator
There was a problem hiding this comment.
@iopapamanoglou I assume this is to pretty-print the control output to a file for help w/ debugging, so temp? Removed it in a merge resolution. If we want to maintain the same functionality, we'll need to do it another way
Contributor
Author
There was a problem hiding this comment.
Yes, was an accidental commit
| @@ -31,12 +31,12 @@ def __init__(self, faulting_ifs: Sequence[ModuleInterface], *args: object) -> No | |||
|
|
|||
|
|
|||
| class ERCFaultElectricPowerUndefinedVoltage(ERCFault): | |||
Collaborator
There was a problem hiding this comment.
This is no longer used. It was useful before because we could downgrade it to a warning. We should either remove it or raise (and continue to downgrade) them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move over to constraint based, lazily evaluated parameters.
New approach builds expression trees that are solved for when queried.