Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Symmetric Inequality Uncorrelated #615

Open
mawildoer opened this issue Dec 3, 2024 · 0 comments
Open

Implement Symmetric Inequality Uncorrelated #615

mawildoer opened this issue Dec 3, 2024 · 0 comments
Assignees
@NoR8quoh1r @iopapamanoglou
Labels
bug Something isn't working
Milestone
v0.3.0

Comments

@mawildoer
Copy link
Contributor

Tests skipped for now:

atopile/test/core/solver/test_solver.py

Lines 237 to 257 in 2348f8d

p0 = Parameter(units=P.V)
p1 = Parameter(units=P.V)
p0.alias_is(Range(0 * P.V, 10 * P.V))
(p0 >= p1).constrain()
(p0 <= p1).constrain()
# This would only work if p0 is alias p1
# but we never do implicit alias, because that's very dangerous
# so this has to throw
# strategy: if this kind of unequality exists, check if there is an alias
# and if not, throw
G = p0.get_graph()
solver = DefaultSolver()
with pytest.raises(Contradiction):
solver.phase_1_simplify_analytically(G)

@mawildoer mawildoer added the bug Something isn't working label Dec 3, 2024
@mawildoer mawildoer added this to the v0.3.0 milestone Dec 3, 2024
mawildoer added a commit that referenced this issue Dec 3, 2024
@mawildoer
Skip test_symmetric_inequality_uncorrelated see: #615
569f8e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoR8quoh1r NoR8quoh1r

@iopapamanoglou iopapamanoglou

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
3 participants
@mawildoer @NoR8quoh1r @iopapamanoglou