frametrim: add backend for D3D9 API #926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would be useful to e.g. show removed calls as comments. Signed-off-by: Danylo Piliaiev <[email protected]>
Signed-off-by: Danylo Piliaiev <[email protected]>
Would make possible to remap pointers. Signed-off-by: Danylo Piliaiev <[email protected]>
A lot of time spent in it while it is not used anywhere. Signed-off-by: Danylo Piliaiev <[email protected]>
Signed-off-by: Louis-Francis Ratté-Boulianne <[email protected]>
Limitations, by importance: - Resource ::Lock/::Unlock should match in the rendering frame, otherwise unmatched function would be called several times during looping. - State block doesn't capture shaders constants in setup frames. - Not all useless memory writes are eliminated, only discards of vertex and index buffers, so in some cases the trimmed result may have a large size. Misc: - keep_all_states option isn't implemented. Signed-off-by: Danylo Piliaiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limitations, by importance:
::Lock/::Unlockshould match in the rendering frame,otherwise unmatched function would be called several times
during looping.
vertex and index buffers, so in some cases the trimmed result
may have a large size.
Misc:
Tested on:
::Lock/::Unlockin the rendering frame