Allow building using system versions instead of thirdparty submodules #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orted by GenerateVersion.cmake when the version cannot be determined from git history (e.g. building from a tarball instead of from a git clone)
spillner
force-pushed
the
allow-system-libraries
branch
from
f44f8d2 to
6e0b97f
Compare
|
The idea looks good to me, could you do "full package"? https://udd.debian.org/patches.cgi?src=apitrace&version=11.1%2Brepack-1.2 For example if I drop snappy from submodules, it won't allow me replace it with system package as a default, so if you could cleanly incorporate these patches, that would be awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #891.