cli_info: implement ProcessName reporting #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfonseca
reviewed
Jun 28, 2022
example output:
```
./apitrace info ~/Downloads/unigi/Unigine_Heaven-4.0/bin/heaven_x64.trace
{
"FileName": "/home/okias/Downloads/unigi/Unigine_Heaven-4.0/bin/heaven_x64.trace",
"ProcessName": "/home/okias/Downloads/unigi/Unigine_Heaven-4.0/bin/heaven_x64",
"ContainerVersion": 6,
"ContainerType": "Snappy",
"API": "OpenGL + GLX/WGL/CGL",
"FramesCount": 11252,
"ActualDataSize": 524912758,
"ContainerSize": 345934639
}
```
When `glretrace` will be invoked as shown below:
```
export TRACE=~/Downloads/unigi/Unigine_Heaven-4.0/bin/heaven_x64.trace
(exec -a "$(./apitrace info ${TRACE} | jq '.["ProcessName"]')" ./glretrace ${TRACE})
```
Mesa library will see it under original application or game name, which
will retain drirc hacks needed for specific broken app/game to work
(thus for trace to correctly replay).
Signed-off-by: David Heidelberg <[email protected]>
jrfonseca
requested changes
Jul 6, 2022
| @@ -81,6 +81,13 @@ getApiName(int api) { | |||
| return trace::API_NAMES[api]; | |||
| } | |||
|
|
|||
| static const std::string | |||
| getProcessName(std::string name) { | |||
| if (name == "") | |||
There was a problem hiding this comment.
if (name.empty)() , but per comment below, we can omit this function entilrely.
| @@ -119,6 +127,9 @@ command(int argc, char *argv[]) | |||
| return 1; | |||
| } | |||
|
|
|||
| auto &properties = p.getProperties(); | |||
| std::string processName = properties.find("process.name")->second; | |||
There was a problem hiding this comment.
This still looks incorrect to me.
Here properties is a std::map, and std::map::find returns end iterator when nothing is found, and per https://en.cppreference.com/w/cpp/container/map/end "attempting to access it results in undefined behavior."
Please use the standard std::map::find pattern for this. That is, something along the lines of:
auto & it = properties.find("process.name");
if (it == properties.end()) {
std::cout << "none";
} else {
std::cout << '\"' << it->second << '\"';
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example output:
When
glretracewill be invoked as shown below:Mesa3D library will see it under original application or game name, which
will retain drirc hacks needed for specific broken app/game to work
(thus for trace to correctly replay).
Signed-off-by: David Heidelberg [email protected]