gui: make image viewer windows maximizable #666
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat. Thanks |
|
@ChipmunkV, you marked this as draft/work-in-progress. Was that intentional? |
|
@jrfonseca yes, it's a draft. Since I can't make them stay on top reliably it's not convenient (there is maybe a hack that works on some systems). So the better thing to do is to keep it a dialog like before, but bind the maximize action (if it works for the dialogs) to the double-click on the image itself like the youtube videos or all image viewers do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageViewer is a dialog window with no maximizing ability (double-click on the header of the window doesn't maximize, there is no maximize button). So making it a proper window.
Side effect with this patch is that the viewer windows can be behind the main window.