glretrace: Implement --borderless option for xlib #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlunarg
force-pushed
the
davidlunarg_borderless
branch
from
0befa29 to
949e58d
Compare
Option --borderless is stubbed out on Windows
|
It looks like macOS build is still broken. |
|
BTW, forgot to mention, I agree this is a nice idea. In fact I felt the need for something similar for windows. |
|
Yep, when I submitted this pull request, I found that MacOS didn't compile. I didn't have a MacOS system to try out fixes on, so I put it aside. Presently, this is a lower priorty for me, I'll get to it sometime in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a pull request that implements the --borderless option. We have found it useful for replaying traces that were created from an app that runs in a full-screen borderless window.
Unfortunately, this is implemented for xlib only. I don't think it would be that difficult to extend this for other platforms.