Skip to content

[Feature] Unify HTTP Source Connector and eventmesh-webhook module #4825

Closed
@Pil0tXia

Description

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

For the eventmesh-webhook module, it currently has these shortcomings:

  • It only supports GitHub webhook protocol for now and it needs to support a more general protocol;
  • Its implementation is too unique in EventMesh, which is hard to manage and extend
  • It has some redundancy in functionality with the HTTP Source Connector and GitHub Source Connector, which needs to be revamped.

This issue brings about a change from thinking of the Runtime as an HTTP Webhook server to thinking of the Connector as an HTTP Webhook server for enhanced extensibility and manageability.

This issue can be resolved in the following steps:

  • Use the existing implementation of Webhook as an enhancement to the HTTP Source Connector, needs to be able to support the user's own implementation of a customized Webhook protocol: [Feature] Add Webhook support for HTTP Source Connector #4869
  • Supporting GitHub webhook protocol may supersed the webhook function of GitHub Source Connector, which means that there's no need to support Webhook in [Feature] Add Github source connector #4416.
  • Deprecate eventmesh-webhook module and its special usages in eventmesh-runtime. (Link the PR resolving this task to this issue.)

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions