DRILL-7093 Batch Sizing in SingleSender #1691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanumathRao
reviewed
Mar 19, 2019
|
|
||
| @Override | ||
| public WritableBatch getWritableBatch(int startIndex, int length) { | ||
| VectorContainer partialContainer = new VectorContainer(context.getAllocator(), getSchema()); |
There was a problem hiding this comment.
Looks like getWritableBatch in MergingRecordBatch, SpilledRecordBatch, AbstractRecordBatch and RecordBatchLoader is same. Is there any way to write a common function in the hierarchy and use it in all these scenarios?
HanumathRao
reviewed
Mar 19, 2019
| @@ -88,6 +88,11 @@ public WritableBatch getWritableBatch() { | |||
| throw new UnsupportedOperationException(); | |||
| } | |||
|
|
|||
| @Override | |||
| public WritableBatch getWritableBatch(int start, int length) { | |||
| throw new UnsupportedOperationException(); | |||
There was a problem hiding this comment.
Should there be a string in similar lines to that of SchemalessBatch exception.
|
Code changes look good to me. I have few minor comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes for implementing batch sizing in SingleSender. The sizing is done by using the RecordBatchSizer.