remove redundant jl_show entry point

ihnorton · JeffBezanson · commit 1f05ba937c8f · 2017-04-12T23:17:29.000-04:00
diff --git a/examples/embedding/embedding.c b/examples/embedding/embedding.c
@@ -94,7 +94,7 @@ int main()
         jl_eval_string("this_function_does_not_exist()");
 
         if (jl_exception_occurred()) {
-            jl_show(jl_stderr_obj(), jl_exception_occurred());
+            jl_call2(jl_get_function(jl_base_module, "show"), jl_stderr_obj(), jl_exception_occurred());
             jl_printf(jl_stderr_stream(), "\n");
         }
 
diff --git a/src/jlapi.c b/src/jlapi.c
@@ -80,7 +80,6 @@ JL_DLLEXPORT jl_value_t *jl_eval_string(const char *str)
         jl_exception_clear();
     }
     JL_CATCH {
-        //jl_show(jl_stderr_obj(), jl_exception_in_transit);
         r = NULL;
     }
     return r;
diff --git a/src/julia.h b/src/julia.h
@@ -1667,7 +1667,6 @@ JL_DLLEXPORT JL_STREAM *jl_stdin_stream(void);
 JL_DLLEXPORT JL_STREAM *jl_stderr_stream(void);
 
 // showing and std streams
-JL_DLLEXPORT void jl_show(jl_value_t *stream, jl_value_t *v);
 JL_DLLEXPORT void jl_flush_cstdio(void);
 JL_DLLEXPORT jl_value_t *jl_stdout_obj(void);
 JL_DLLEXPORT jl_value_t *jl_stderr_obj(void);
diff --git a/src/rtutils.c b/src/rtutils.c
@@ -439,24 +439,6 @@ JL_DLLEXPORT jl_value_t *jl_stderr_obj(void)
     return stderr_obj;
 }
 
-static jl_function_t *jl_show_gf=NULL;
-
-JL_DLLEXPORT void jl_show(jl_value_t *stream, jl_value_t *v)
-{
-    if (jl_base_module) {
-        if (jl_show_gf == NULL) {
-            jl_show_gf = (jl_function_t*)jl_get_global(jl_base_module, jl_symbol("show"));
-        }
-        if (jl_show_gf==NULL || stream==NULL) {
-            jl_printf(JL_STDERR, " could not show value of type %s",
-                      jl_symbol_name(((jl_datatype_t*)jl_typeof(v))->name->name));
-            return;
-        }
-        jl_value_t *args[3] = {jl_show_gf,stream,v};
-        jl_apply(args, 3);
-    }
-}
-
 // toys for debugging ---------------------------------------------------------
 
 static size_t jl_show_svec(JL_STREAM *out, jl_svec_t *t, const char *head, const char *opn, const char *cls)
@@ -868,8 +850,7 @@ static size_t jl_static_show_x_(JL_STREAM *out, jl_value_t *v, jl_datatype_t *vt
 
 static size_t jl_static_show_x(JL_STREAM *out, jl_value_t *v, struct recur_list *depth)
 {
-    // mimic jl_show, but never calling a julia method and
-    // never allocate through julia gc
+    // show values without calling a julia method or allocating through the GC
     if (v == NULL) {
         return jl_printf(out, "#<null>");
     }
diff --git a/src/toplevel.c b/src/toplevel.c
@@ -461,8 +461,6 @@ static jl_method_instance_t *jl_new_thunk(jl_code_info_t *src, jl_module_t *modu
 jl_value_t *jl_toplevel_eval_flex(jl_value_t *e, int fast, int expanded)
 {
     jl_ptls_t ptls = jl_get_ptls_states();
-    //jl_show(ex);
-    //jl_printf(JL_STDOUT, "\n");
     if (!jl_is_expr(e)) {
         if (jl_is_linenode(e)) {
             jl_lineno = jl_linenode_line(e);
diff --git a/ui/repl.c b/ui/repl.c
@@ -52,7 +52,7 @@ static int exec_program(char *program)
         jl_value_t *errs = jl_stderr_obj();
         jl_value_t *e = ptls->exception_in_transit;
         // Manually save and restore the backtrace so that we print the original
-        // one instead of the one caused by `jl_show`.
+        // one instead of the one caused by `show`.
         // We can't use safe_restore since that will cause any error
         // (including the ones that would have been caught) to abort.
         uintptr_t *volatile bt_data = NULL;
@@ -61,7 +61,7 @@ static int exec_program(char *program)
             if (errs) {
                 bt_data = (uintptr_t*)malloc(bt_size * sizeof(void*));
                 memcpy(bt_data, ptls->bt_data, bt_size * sizeof(void*));
-                jl_show(errs, e);
+                jl_call2(jl_get_function(jl_base_module, "show"), errs, e);
                 jl_printf(JL_STDERR, "\n");
                 free(bt_data);
             }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ int main()`
`94`	`94`	`jl_eval_string("this_function_does_not_exist()");`
`95`	`95`
`96`	`96`	`if (jl_exception_occurred()) {`
`97`		`- jl_show(jl_stderr_obj(), jl_exception_occurred());`
	`97`	`+ jl_call2(jl_get_function(jl_base_module, "show"), jl_stderr_obj(), jl_exception_occurred());`
`98`	`98`	`jl_printf(jl_stderr_stream(), "\n");`
`99`	`99`	`}`
`100`	`100`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ JL_DLLEXPORT jl_value_t jl_eval_string(const char str)`
`80`	`80`	`jl_exception_clear();`
`81`	`81`	`}`
`82`	`82`	`JL_CATCH {`
`83`		`- //jl_show(jl_stderr_obj(), jl_exception_in_transit);`
`84`	`83`	`r = NULL;`
`85`	`84`	`}`
`86`	`85`	`return r;`
Original file line number	Diff line number	Diff line change
`@@ -461,8 +461,6 @@ static jl_method_instance_t jl_new_thunk(jl_code_info_t src, jl_module_t *modu`
`461`	`461`	`jl_value_t jl_toplevel_eval_flex(jl_value_t e, int fast, int expanded)`
`462`	`462`	`{`
`463`	`463`	`jl_ptls_t ptls = jl_get_ptls_states();`
`464`		`- //jl_show(ex);`
`465`		`- //jl_printf(JL_STDOUT, "\n");`
`466`	`464`	`if (!jl_is_expr(e)) {`
`467`	`465`	`if (jl_is_linenode(e)) {`
`468`	`466`	`jl_lineno = jl_linenode_line(e);`