Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: resizeMode prop is not implemented on web #4297

Open
gigobyte opened this issue Nov 21, 2024 · 3 comments
Open

[BUG]: resizeMode prop is not implemented on web #4297

gigobyte opened this issue Nov 21, 2024 · 3 comments

Comments

@gigobyte
Copy link

Version

6.8.0

What platforms are you having the problem on?

Windows

System Version

Chrome

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

The object-fit style property of the video element in Video.web.tsx should respect the resizeMode prop.

Reproduction Link

repository link

Reproduction

Step to reproduce this bug are:

  1. Set resizeMode to "cover"
  2. Observe video in a web browser
@gigobyte gigobyte added the bug label Nov 21, 2024
Copy link

Thank you for your issue report. Please note that the following information is missing or incomplete:

  • reproduction link

Please update your issue with this information to help us address it more effectively.

Note: issues without complete information have a lower priority

@freeboub
Copy link
Collaborator

@zoriya Can I ping you on web ticket ? :) not sure you receive a notifcation on all ticket and / or you have time to handle them ?! Thank you !

@zoriya
Copy link
Contributor

zoriya commented Nov 29, 2024

Sure!

I wanted to wait for bun before starting a new PR to prevent a huge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants