-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stackstorm UI not masking the secret values #6272
Comments
This is not a bug, but rather you expecting it to do something it's not meant to do. The secret masking works only on fields and inputs marked as secret. If you enter a password into a plaintext field that's not marked as such, the engine is going to display it as a non-secret. Even with "secret" fields be aware that: |
How do we mark something as a secret other than using "--encrypt" when we store it in the database? In my request I didn't type in the password in plain text, I referred to a key which was marked as a secret Also, how come its masked in the CLI and API but not GUI. Similar to API and log below [log] Maybe we can add a similar option to |
In the yaml definition of the action. In this case you'd have to fork the st2_pack install action |
SUMMARY
Provide a quick summary of your bug report.
The API and Logs have the option to mask the secrets but the execution history in the GUI is showing the secrets in plain text
STACKSTORM VERSION
Paste the output of
st2 --version
:st2 3.8.1, on Python 3.8.10
OS, environment, install method
Ubuntu, Docker
Post what OS you are running this on, along with any other relevant information/
Steps to reproduce the problem
st2 key set github_key test-value --encrypt
GUI:
Actions -> Packs -> download
Packs:
https://:{{ st2kv.system.github_key | decrypt_kv }}@
CLI
st2 pack install https://:{{ st2kv.system.github_key | decrypt_kv }}@
Show how to reproduce the problem, using a minimal test-case. Make sure to include any content
(pack content - workflows, actions, etc.) which are needed to reproduce the problem.
Expected Results
What did you expect to happen when running the steps above?
https://:******@
Actual Results
cmdline: git clone -v -- https://:@
But GUI is showing the key in plain text
What happened? What output did you get?
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!
The text was updated successfully, but these errors were encountered: