Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option for no parsing. #1404

Open
aevo98765 opened this issue Oct 21, 2024 · 2 comments
Open

Add the option for no parsing. #1404

aevo98765 opened this issue Oct 21, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@aevo98765
Copy link

🚀 The feature

I would like a response value in the following format:

{"type": "dataframe", "value": "xyz"}

Motivation, pitch

This would allow downstream programmatic handling of the different potential responses types.

Alternatives

No response

Additional context

As it stands I believe it works like this:

If no response_parser is passed to the SmartDataframe then the response is parsed to just include the result["value"]. I think that potentially the default should be to return both the type and value. Then in the config add an option to parse just the value.

Also, as it stands I have not contributed to this project but I would like the opportunity to implement this change if possible?

@dosubot dosubot bot added the enhancement New feature or request label Oct 21, 2024
@aevo98765
Copy link
Author

PS assign this issue to me if you are happy for this to be implemented. Cheers.

@gventuri gventuri assigned gventuri and aevo98765 and unassigned gventuri Oct 22, 2024
@gventuri
Copy link
Collaborator

Hi @aevo98765, just assigned the issue to you, thanks a lot for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants