Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some imgur gifv files get rejected with 404 because downloader used wrong url #921

Open
3 tasks done
staridiot opened this issue Aug 9, 2023 · 3 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@staridiot
Copy link

  • I am reporting a bug.
  • I am running the latest version of BDfR
  • I have read the Opening an issue

Description

The downloader for Imgur seems to occasionally try to download some gifv files from https://api.imgur.com/3/image/x instead of https://i.imgur.com/x.gifv. The link works/exists at the time of writing this.

Command


Fair warning: These imgur links are NSFW, open at your discretion.

Works (https://i.imgur.com/N1nyc6i.gifv):
bdfr download ./test -v -l 15mb93a

Does not work (https://i.imgur.com/OfqW3bs.gifv):
bdfr download ./test -v -l 15mb2df

Environment (please complete the following information)

  • OS: Ubuntu 22.04.2
  • Python version: 3.9.16

Logs

sysadmin@mediaserver:/test$ python3.9 -m bdfr download ./test -v -l 15mb93a
[2023-08-09 09:52:22,432 - bdfr.connector - DEBUG] - Disabling the following modules:
[2023-08-09 09:52:22,434 - bdfr.connector - DEBUG] - Using unauthenticated Reddit instance
Version 7.6.1 of praw is outdated. Version 7.7.1 was released Tuesday July 11, 2023.
[2023-08-09 09:52:22,696 - bdfr.downloader - DEBUG] - Attempting to download submission 15mb93a
[2023-08-09 09:52:22,697 - bdfr.downloader - DEBUG] - Using Imgur with url https://i.imgur.com/N1nyc6i.gifv
[2023-08-09 09:52:23,036 - bdfr.downloader - DEBUG] - Written file to /test/test/u_AzalyaStar/AzalyaStar_15mb93a.mp4
[2023-08-09 09:52:23,036 - bdfr.downloader - INFO] - Downloaded submission 15mb93a from u_AzalyaStar
[2023-08-09 09:52:23,036 - bdfr.downloader - DEBUG] - Hash added to master list: f6f90c0053a1c8a86b47d912b8b7d51f
[2023-08-09 09:52:23,036 - root - INFO] - Program complete
sysadmin@mediaserver:/test$ python3.9 -m bdfr download ./test -v -l 15mb2df
[2023-08-09 09:52:44,528 - bdfr.connector - DEBUG] - Disabling the following modules:
[2023-08-09 09:52:44,530 - bdfr.connector - DEBUG] - Using unauthenticated Reddit instance
Version 7.6.1 of praw is outdated. Version 7.7.1 was released Tuesday July 11, 2023.
[2023-08-09 09:52:44,820 - bdfr.downloader - DEBUG] - Attempting to download submission 15mb2df
[2023-08-09 09:52:44,820 - bdfr.downloader - DEBUG] - Using Imgur with url https://i.imgur.com/OfqW3bs.gifv
[2023-08-09 09:52:45,007 - bdfr.downloader - ERROR] - Site Imgur failed to download submission 15mb2df: Server responded with 404 to https://api.imgur.com/3/image/OfqW3bs
[2023-08-09 09:52:45,008 - root - INFO] - Program complete
@staridiot staridiot added the bug Something isn't working label Aug 9, 2023
@Fakeaccount12312
Copy link

Just saying, both links don't work anymore.

@ymgenesis
Copy link

ymgenesis commented Mar 1, 2024

This is still an issue. When attempting to download this post: nsfw nudity, bdfr uses this link: and fails, looks like it's requesting authorization for access to the imgur api.

The first link (working at time of post) will probably be removed eventually as imgur doesn't allow nsfw anymore, I believe. Still, there are endless examples popping up everyday. There's a working link and it's not grabbing it correctly by trying to use the imgur api.

@Serene-Arc
Copy link
Owner

Hi, do you have a current example of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants