Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs_fat32.c fat_seek maybe return a error that shoud ok #29

Open
elmagnificogi opened this issue Aug 18, 2018 · 3 comments
Open

fs_fat32.c fat_seek maybe return a error that shoud ok #29

elmagnificogi opened this issue Aug 18, 2018 · 3 comments
Assignees
@davids5
Labels
bug

Comments

@elmagnificogi
Copy link

elmagnificogi commented Aug 18, 2018 •
edited by AuterionWrikeBot
Loading

Use case:
open a file with readonly,then lseek to the end with offset 0
there will return a error( ENOSPC 28 "No space left on device")
so i can't get the file size with this.

TestFile:13,107,200 Byte

Code:

static off_t fat_seek(FAR struct file filep, off_t offset, int whence)
---------1164
if ((ff->ff_oflags & O_WROK) != 0)
{
/ Extend the cluster chain (fat_extendchain
* will follow the existing chain or add new
* clusters as needed.
*/

cluster = fat_extendchain(fs, cluster);
}
else
{
/* Otherwise we can only follow the existing chain */

cluster = fat_getcluster(fs, cluster);
}

---------1178

when i debug i found that fat_getcluster(fs, cluster) will retrun the "0x0fffffff" that means FAT cluster end.
but in fat_seek ,there is no end deal,so there will be a error.

The break way is less than clustersize,in the loop， position Just coincidentally equal to clustersize,so it continue find next cluster chan.

---------1142

if (position < clustersize)
{
break;
}

---------1145

Solution:

add FAT end deal or make break condition wiht "position <= clustersize"
@bkueng
Copy link
Member

bkueng commented Aug 20, 2018

@davids5 can you take a look?

@davids5 davids5 self-assigned this Aug 20, 2018
@dagar dagar added the bug label Jan 2, 2019
@dagar
Copy link
Member

dagar commented Jan 2, 2019

Is this still an issue?

@elmagnificogi
Copy link
Author

Is this still an issue?

no one reply,i have no idea

PX4BuildBot pushed a commit that referenced this issue Jan 5, 2020
@gregory-nutt
Author: Gregory Nutt <[email protected]>
0ee8241 
    Run all .c and .h files in last PR through tools/nxstyle and fix all complaints.

Author: macman88 <[email protected]>

    LPC17xx serial updates (#29)

    * Save CONFIG_ARCH_BOARD_CUSTOM when running 'make savedefconfig'
    * Don't compile up_earlyserialinit if USE_EARLYSERIALINIT is not defined
    * Added support for RS485 direction control on LPC17xx UART1
    * First pass at fractional baud rate divider on LPC17xx/40xx
    * Added support for fractional divider to console UART
PX4BuildBot pushed a commit that referenced this issue Jan 5, 2020
@gregory-nutt
Author: Gregory Nutt <[email protected]>
2797048 
    Run all .c and .h files in last PR through tools/nxstyle and fix all complaints.

Author: macman88 <[email protected]>

    LPC17xx serial updates (#29)

    * Save CONFIG_ARCH_BOARD_CUSTOM when running 'make savedefconfig'
    * Don't compile up_earlyserialinit if USE_EARLYSERIALINIT is not defined
    * Added support for RS485 direction control on LPC17xx UART1
    * First pass at fractional baud rate divider on LPC17xx/40xx
    * Added support for fractional divider to console UART
PX4BuildBot pushed a commit that referenced this issue Oct 11, 2024
@GUIDINGLI @xiaoxiang781216
sem: fix assert failed when open CONFIG_PRIORITY_INHERITANCE
6e68dde 
set CONFIG_PRIORITY_INHERITANCE=y
set CONFIG_SEM_PREALLOCHOLDERS=0 or CONFIG_SEM_PREALLOCHOLDERS=8

    #24 0x4dcab71 in __assert assert/lib_assert.c:37
    #25 0x4d6b0e9 in nxsem_destroyholder semaphore/sem_holder.c:602
    #26 0x4d80cf7 in nxsem_destroy semaphore/sem_destroy.c:80
    #27 0x4d80db9 in sem_destroy semaphore/sem_destroy.c:120
    #28 0x4dcb077 in nxmutex_destroy misc/lib_mutex.c:122
    #29 0x4dc6611 in pipecommon_freedev pipes/pipe_common.c:117
    #30 0x4dc7fdc in pipecommon_close pipes/pipe_common.c:397
    #31 0x4ed4f6d in file_close vfs/fs_close.c:78
    #32 0x6a91133 in local_free local/local_conn.c:184
    #33 0x6a92a9c in local_release local/local_release.c:129
    #34 0x6a91d1a in local_subref local/local_conn.c:271
    #35 0x6a75767 in local_close local/local_sockif.c:797
    #36 0x4e978f6 in psock_close socket/net_close.c:102
    #37 0x4eed1b9 in sock_file_close socket/socket.c:115
    #38 0x4ed4f6d in file_close vfs/fs_close.c:78
    #39 0x4ed1459 in nx_close_from_tcb inode/fs_files.c:754
    #40 0x4ed1501 in nx_close inode/fs_files.c:781
    #41 0x4ed154a in close inode/fs_files.c:819
    #42 0x6bcb9ce in property_get kvdb/client.c:307
    #43 0x6bcd465 in property_get_int32 kvdb/common.c:270
    #44 0x5106c9a in tz_offset_restore app/miwear_bluetooth.c:745
    #45 0x510893f in miwear_bluetooth_main app/miwear_bluetooth.c:1033
    #46 0x4dcf5c8 in nxtask_startup sched/task_startup.c:70
    #47 0x4d70873 in nxtask_start task/task_start.c:134
    #48 0x4e04a07 in pre_start sim/sim_initialstate.c:52

Signed-off-by: ligd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davids5 davids5

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dagar @bkueng @davids5 @elmagnificogi