Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Following files added: #716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MountyRox
Copy link
Contributor

Hi,
this is my vey first pull request, hope it is OK like it is.

On branch mountyrox
Changes to be committed:
new file: Connector_Coaxial.3dshapes/SMA_Amphenol_132134_10_Vertical.step
new file: Connector_Coaxial.3dshapes/SMA_Amphenol_132134_10_Vertical.wrl
new file: Connector_Coaxial.3dshapes/SMA_Amphenol_132134_11_Vertical.step
new file: Connector_Coaxial.3dshapes/SMA_Amphenol_132134_11_Vertical.wrl
new file: Connector_Coaxial.3dshapes/SMA_Amphenol_132289_EdgeMount.step
new file: Connector_Coaxial.3dshapes/SMA_Amphenol_132289_EdgeMount.wrl
new file: Connector_Coaxial.3dshapes/SMA_Molex_73251_1153_EdgeMount_Horizontal.step
new file: Connector_Coaxial.3dshapes/SMA_Molex_73251_1153_EdgeMount_Horizontal.wrl

The original KiCAD source files will be pushed to 'KiCad/kicad-packages3D-source'
Screenshot SMA_Amphenol_132134_11_Vertical:
SMA_Amphenol_132134_11_Vertical

Screenshot SMA_Amphenol_132134-10_Vertical, top and bottom view:
SMA_Amphenol_132134-10_Vertical_bottom

SMA_Amphenol_132134-10_Vertical

Screenshot SMA_Amphenol_132289_EdgeMount:
SMA_Amphenol_132289_EdgeMount

Screenshot SMA_Molex_73251-1153_EdgeMount_Horizontal:
SMA_Molex_73251-1153_EdgeMount_Horizontal

  • [x ] A screenshot of the model(s) aligned with KiCad footprint(s)
  • [in process ] Source files are contributed on the apropriate location
  • [x ] Step model submitted in 1:1 scale
  • [x ] WRL model submitted in 1:2.54 scale
  • [ x] 3D model alignment checked against KiCad footprint
  • [hope I did it right ] WRL model uses correct material properties
  • [x ] Geometry check performed on the model

 On branch mountyrox
 Changes to be committed:
	new file:   Connector_Coaxial.3dshapes/SMA_Amphenol_132134_10_Vertical.step
	new file:   Connector_Coaxial.3dshapes/SMA_Amphenol_132134_10_Vertical.wrl
	new file:   Connector_Coaxial.3dshapes/SMA_Amphenol_132134_11_Vertical.step
	new file:   Connector_Coaxial.3dshapes/SMA_Amphenol_132134_11_Vertical.wrl
	new file:   Connector_Coaxial.3dshapes/SMA_Amphenol_132289_EdgeMount.step
	new file:   Connector_Coaxial.3dshapes/SMA_Amphenol_132289_EdgeMount.wrl
	new file:   Connector_Coaxial.3dshapes/SMA_Molex_73251_1153_EdgeMount_Horizontal.step
	new file:   Connector_Coaxial.3dshapes/SMA_Molex_73251_1153_EdgeMount_Horizontal.wrl

The original KiCAD source files will be pushed to 'KiCad/kicad-packages3D-source'
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Aug 13, 2020
@MountyRox MountyRox closed this Sep 1, 2020
@MountyRox MountyRox deleted the mountyrox branch September 1, 2020 15:03
@myfreescalewebpage
Copy link
Collaborator

@MountyRox why closing ? The models looks fine and interesting :)

@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 2, 2020
@MountyRox MountyRox restored the mountyrox branch September 3, 2020 04:36
@MountyRox
Copy link
Contributor Author

Ups, i thought the files were merged already. I restored the branch and reopened the PR. I hope this is the right way to proceed.
@myfreescalewebpage: Thank's for your note!

@MountyRox MountyRox reopened this Sep 3, 2020
@myfreescalewebpage myfreescalewebpage added the Pending reviewer A pull request waiting for a reviewer label Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants