Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gentle subnanos for issue #3 #5

Merged
merged 13 commits into from
Jul 26, 2022
Merged

Gentle subnanos for issue #3 #5

merged 13 commits into from
Jul 26, 2022

Conversation

JeffreySarnoff
Copy link
Member

No description provided.

rounding (really anything but flooring [to handle both negative and nonnegative values) would be incompatible with future femtosecond resolved times.
 one floors the extra trailing digits (the digits that are more precise than the data structure can hold or than the functions can process properly),
 to ensure the code that rolls up over periods works correctly: this must not fail when moving from a microsecond limited system to a nanosecond limited one:
`±999.9microsecs == ±999_900nanosecs == Microsecond(±999) + Nanosecond(±900)`.
@coveralls
Copy link

coveralls commented Jul 26, 2022

Pull Request Test Coverage Report for Build 2739578617

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 40.397%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/strings.jl 4 5 80.0%
Totals Coverage Status
Change from base Build 2739546206: -0.1%
Covered Lines: 427
Relevant Lines: 1057

💛 - Coveralls

@JeffreySarnoff JeffreySarnoff merged commit 25f35d2 into main Jul 26, 2022
@JeffreySarnoff JeffreySarnoff deleted the gentle_subnanos branch July 26, 2022 12:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2738683575

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 40.454%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/strings.jl 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/strings.jl 6 45.65%
Totals Coverage Status
Change from base Build 2738627028: 0.4%
Covered Lines: 428
Relevant Lines: 1058

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 2738817345

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • 91 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-7.9%) to 31.989%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/strings.jl 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/strings.jl 28 36.09%
src/timestamp.jl 31 0.0%
src/ndnow.jl 32 18.0%
Totals Coverage Status
Change from base Build 2738627028: -7.9%
Covered Lines: 341
Relevant Lines: 1066

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants