Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KT-49155 Fix KGP compatibility with test-retry and test-distribution plugins #5381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osipxd
Copy link

@osipxd osipxd commented Nov 28, 2024

Gradle plugins can use internal API to wrap test executor and set it to Test.testExecuter field. KGP overrides createTestExecutor ignoring this possibility. So in result testExecutor might be wrapped several times with KGP's executor.

For example, when the test-retry plugin is applied, we get the following test executor hierarchy:

KotlinJvmTarget$Executor(
  RetryTestExecuter(
    KotlinJvmTarget$Executor(
      DefaultTestExecuter
    )
  )
)

This breaks two things:

  • Tests naming as targetName is appended twice
  • Test retry itself, as it needs the executor to be an instance of RetryTestExecutor.

Fixes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant