Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KT-72027: [Gradle, JS] Support Windows on ARM #5367

Conversation

Kai-Z-JP
Copy link
Contributor

@Kai-Z-JP Kai-Z-JP commented Oct 7, 2024

KT-72027 JS target build fails on ARM64 Windows

Build fails when building Kotlin Multiplatform JS target on Windows on ARM.
It appears to fail because it is trying to call the uname command, which does not exist in Windows.

This change adds support for the kotlin-gradle-plugin js target for Windows on ARM, which ported from node-gradle changes.
node-gradle/gradle-node-plugin#315
node-gradle/gradle-node-plugin@8b2f4cf#diff-afa737f9e45b97c369ddea14513270b563ac29801e8b42148f670f18aae703a7.

@Kai-Z-JP Kai-Z-JP marked this pull request as ready for review October 7, 2024 16:54
@ilgonmic ilgonmic self-assigned this Dec 6, 2024
@ilgonmic ilgonmic force-pushed the kotlin-gradle-plugin-js-windows-on-arm branch from 0d39676 to e39c2b1 Compare December 6, 2024 15:06
@ilgonmic
Copy link
Contributor

ilgonmic commented Dec 9, 2024

Merged manually
Thank you!
aabb6b5

@ilgonmic ilgonmic closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants