Add configurable update time for Docker version #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Guovin#440 Add configuration for scheduled updates in Docker version. * **Dockerfile** - Add `UPDATE_CRON` environment variable to allow custom cron schedules. - Modify the `RUN` command to use the `UPDATE_CRON` variable for setting the cron jobs. * **config/config.ini** - Add a new setting `update_cron` for specifying the cron schedule. * **docs/tutorial.md** - Update the documentation to explain how to configure the update time or interval for the Docker version. * **docs/tutorial_en.md** - Update the documentation to explain how to configure the update time or interval for the Docker version.
|
Well done, you've done what I planned to do. The docker container startup also seems to be missing code to read the update_cron configuration in config.ini. I am also optimizing docker related code recently, and I will merge it with your code after I improve it, thank you. |
|
Please push your code to the dev branch, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #440
Add configuration for scheduled updates in Docker version.
Dockerfile
UPDATE_CRONenvironment variable to allow custom cron schedules.RUNcommand to use theUPDATE_CRONvariable for setting the cron jobs.config/config.ini
update_cronfor specifying the cron schedule.docs/tutorial.md
docs/tutorial_en.md