Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build output #266

Open
crystalthoughts opened this issue Aug 24, 2023 · 7 comments
Open

Windows build output #266

crystalthoughts opened this issue Aug 24, 2023 · 7 comments

Comments

@crystalthoughts
Copy link

crystalthoughts commented Aug 24, 2023 •
edited
Loading

Hi, I'm following the instructions for building on Windows. Everything builds successfully but I notice things aren't collected in one folder with submodule directories but inserted into the build folder structure. I have set the CMAKE flag as suggested but it doesn't seem to do anything. Is this expected?

Also, is there a flag I've missed to build the dlls? I don't see it in the configurations list.

Thanks for this great project.
@TheMostDiligent
Copy link
Contributor

You need to build the install cmake target - it will collect libraries and include files in one folder.
DLLs are always buillt.

@crystalthoughts
Copy link
Author

crystalthoughts commented Aug 28, 2023 via email

@crystalthoughts
Copy link
Author

So far I'm doing:
From the Diligent Engine folder:

cmake -S . -B ./build/Win64 -G "Visual Studio 16 2019" -A x64;
cmake --build ./build/Win64 --target install

It builds but it still outputs only .lib/.pdb files and its interspersed with all the build files:

  glslang.vcxproj -> Y:\Projects\Libs\DiligentEngine\build\Win64\DiligentCore\ThirdParty\glslang\glslang\Debug\glslangd
  .lib
  Building Custom Rule Y:/Projects/Libs/DiligentEngine/DiligentCore/ThirdParty/SPIRV-Cross/CMakeLists.txt
  spirv_cross.cpp
  spirv_parser.cpp
  spirv_cross_parsed_ir.cpp
  spirv_cfg.cpp
  Generating Code...
  spirv-cross-core.vcxproj -> Y:\Projects\Libs\DiligentEngine\build\Win64\DiligentCore\ThirdParty\SPIRV-Cross\Debug\spi
  rv-cross-cored.lib
  Building Custom Rule Y:/Projects/Libs/DiligentEngine/DiligentCore/ThirdParty/glew/CMakeLists.txt
  glew.c
  glew-static.vcxproj -> Y:\Projects\Libs\DiligentEngine\build\Win64\DiligentCore\ThirdParty\glew\Debug\glew-static.lib
  Building Custom Rule Y:/Projects/Libs/DiligentEngine/DiligentCore/ThirdParty/xxHash/cmake_unofficial/CMakeLists.txt
  xxhash.c
  xxhash.vcxproj -> Y:\Projects\Libs\DiligentEngine\build\Win64\DiligentCore\ThirdParty\xxHash\cmake_unofficial\Debug\x
  xhash.lib
  Building Custom Rule Y:/Projects/Libs/DiligentEngine/DiligentFX/CMakeLists.txt
        Validating DiligentFX module's source code formatting...
  clang-format validation passed: no issues found in 11 files
  Building Custom Rule Y:/Projects/Libs/DiligentEngine/DiligentSamples/CMakeLists.txt
        Validating DiligentSamples module's source code formatting...
  clang-format validation passed: no issues found in 115 files
  Building Custom Rule Y:/Projects/Libs/DiligentEngine/DiligentTools/CMakeLists.txt
        Validating DiligentTools module's source code formatting...
  clang-format validation passed: no issues found in 110 files
  Building Custom Rule Y:/Projects/Libs/DiligentEngine/DiligentTools/ThirdParty/libjpeg-9e/CMakeLists.txt

Should I be expecting an 'install' folder with all the headers, lib files and dlls in a separate folder hierarchy?

@crystalthoughts
Copy link
Author

crystalthoughts commented Aug 29, 2023 •
edited
Loading

Actually it seems only to build the third party libs at that?
I tried directly building Core with similar commands and it has similar behaviour also with an error, though it does build most of the core libs too.
image

@MikhailGorobets
Copy link
Collaborator

@crystalthoughts You need to install ATL.

@crystalthoughts
Copy link
Author

crystalthoughts commented Aug 29, 2023 •
edited
Loading

Ok thanks. But what about the rest of the build output, is that normal? Seems like a lot of work to fish things out (and only static libs), and I notice the automated builds have everything nicely collected (but only dynamic libs).

@TheMostDiligent
Copy link
Contributor

Ok thanks. But what about the rest of the build output, is that normal?

Your build failed and was aborted.
When it succeeds, the artifacts will be collected in the install folder. If you did not specify it, it will be build/Win64/install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crystalthoughts @MikhailGorobets @TheMostDiligent