-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDoMVC needs fixing and upgrading #76
Comments
@hagbarddenstore did all of the work on this example project. The purpose was two-fold. One - an example to work on in parallel with library to get the user perspective, but then of course to serve as a general working example without anything specific in mind. It surely needs some love, feel free to do what you see fit! I really like the idea of integrating some advice/documentation into the views. Also, related to #79 which suggests adding an ISerializer based on System.Json to the core library and making it the default. |
Ah, great. Happy to upgrade this to 3.1 LTS. and put in some docs.
then I can start looking at a very simple update to the project. |
Looks legit besides the duplicated services.AddSingleton! |
haha...typo from copy and paste, doh! :D |
I threw the todo example away and created a Trello clone instead using .NET Core 3.1 |
I will be looking at this on Thursday. I have take Thursday and Friday off to do some open source coding. |
Hi @rofr what's the status of the TODO MVC Sample app?
does that need to be upgraded to .net core 3.1? What's it's purpose? I couldnt get it to run without making a few small tweaks
As the code currently stands, when you run,
Kestrel
starts, but the memstate builder never builds the singleton instance. If you navigate tohttp://localhost:12202/lists
you get the following errorto fix this I had to change the
ConfigureServices
as follows, fromchange to
Also, if you're not running
postgres
you get an error initialising the serializer, so it's best to addMemstate.JsonNet
packageso that the only
sample project
that users see when they clone the project and press F5 will at least start and run. It's not an unreasonable expectation, which brings me back to wanting to know the purpose of the sample project? If we can define the purpose then I can make some changes to help deliver on that goal.Some idea:
Memstate
configuration andNpgsql
journal provider forpostgres
, if you want to try that out. The default (without this setting) will beMemstate.JsonNet
, which will create a journal file ...etc etc..pester
as part of the build, rather than complicating the unit tests? imho. I can help with that.The text was updated successfully, but these errors were encountered: