tang-show-keys and tangd-keygen now use SHA-256 for the thumbprints #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From release 18, clevis changed to use SHA-256 as the default hash for the JWK thumbprints. Let's update tang-show-keys and tangd-keygen to also do that.
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 50.99% 50.99%
=======================================
Files 3 3
Lines 404 404
Branches 116 116
=======================================
Hits 206 206
Misses 130 130
Partials 68 68 Continue to review full report at Codecov.
|
ZelenyMartin
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From release 18, clevis changed to use SHA-256 as the default hash for
the JWK thumbprints. Let's update tang-show-keys and tangd-keygen to
also do that.