fix(meta): add missing router.base prefix to favicon (#354)

DraftProducts · pi0 · web-flow · commit 3e910ae7e87d · 2020-10-01T11:16:27.000+02:00
* Relative path missing for the favicon

The favicon must be accessible from any page and it does not matter how deep the page is. The only possible solution is to use a relative url.

* Update module.js

Co-authored-by: pooya parsa &lt;pyapar@gmail.com&gt;
diff --git a/lib/meta/module.js b/lib/meta/module.js
@@ -111,7 +111,7 @@ function generateMeta (pwa) {
   if (options.favicon && !find(this.options.head.link, 'rel', 'shortcut icon') && existsSync(favicon)) {
     console.warn('You are using a low quality icon, use icon png. See https://pwa.nuxtjs.org/icon/')
 
-    this.options.head.link.push({ rel: 'shortcut icon', href: 'favicon.ico' })
+    this.options.head.link.push({ rel: 'shortcut icon', href: this.options.router.base + 'favicon.ico' })
   }
 
   // Title

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ function generateMeta (pwa) {`
`111`	`111`	`if (options.favicon && !find(this.options.head.link, 'rel', 'shortcut icon') && existsSync(favicon)) {`
`112`	`112`	`console.warn('You are using a low quality icon, use icon png. See https://pwa.nuxtjs.org/icon/')`
`113`	`113`
`114`		`- this.options.head.link.push({ rel: 'shortcut icon', href: 'favicon.ico' })`
	`114`	`+ this.options.head.link.push({ rel: 'shortcut icon', href: this.options.router.base + 'favicon.ico' })`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`// Title`