Skip to content

Adding a type guard for AxiosError #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jasonsaayman merged 13 commits into from
Nov 3, 2020
Merged

Adding a type guard for AxiosError #2949

jasonsaayman merged 13 commits into from
Nov 3, 2020

Conversation

@JasonHK
Copy link
Contributor

@JasonHK JasonHK commented May 6, 2020 •
edited
Loading

This type guard allows TypeScript users to use the AxiosError interface without typecasting.

Usage

import axios, { isAxiosError } from "axios";

axios.get("/endpoint")
    .catch(
        (error) =>
        {
            if (isAxiosError(error)) { ... }
        });

Fix #1863

jasonsaayman
jasonsaayman reviewed May 6, 2020
View reviewed changes
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good lets add it onto v0.20

@jasonsaayman jasonsaayman added this to the v0.20.0 milestone May 6, 2020
@jasonsaayman jasonsaayman removed this from the v0.20.0 milestone Aug 25, 2020
@JasonHK JasonHK requested a review from jasonsaayman November 3, 2020 06:57
@jasonsaayman jasonsaayman added this to the v0.21.1 milestone Nov 3, 2020
jasonsaayman
jasonsaayman approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and having tests is great 👍

@jasonsaayman jasonsaayman merged commit f472e5d into axios:master Nov 3, 2020
@JasonHK JasonHK deleted the feat/is-axios-error branch November 3, 2020 08:17
This was referenced Jan 5, 2021
Open
Open
This was referenced Mar 18, 2021
Open
Closed
Merged
Open
Open
Merged
Closed
Open
Merged
Merged
Closed
Merged
Open
Merged
Merged
Closed
Merged
Open
Merged
Merged
Merged
Merged
Merged
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 28, 2021
Closed
mbargiel pushed a commit to mbargiel/axios that referenced this pull request Jan 27, 2022
@JasonHK
Adding a type guard for AxiosError (axios#2949)
4945576 
Co-authored-by: Jason Kwok <[email protected]>
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2022
Closed
@Omrisnyk Omrisnyk mentioned this pull request Dec 20, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Jan 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonsaayman jasonsaayman jasonsaayman approved these changes

+1 more reviewer

@BlackHole1 BlackHole1 BlackHole1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.21.1

Development

Successfully merging this pull request may close these issues.

Add a typeguard for discriminating AxiosError type from Error type

6 participants

@JasonHK @boy51 @BlackHole1 @TJGhinder @jasonsaayman @chinesedfan